Scc 4345/add record type #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonword
reviewed
Dec 5, 2024
lib/jsonld_serializers.js
Outdated
| @@ -280,6 +286,13 @@ class ResourceSerializer extends JsonLdItemSerializer { | |||
| } | |||
| } | |||
|
|
|||
| ResourceSerializer.getFormattedRecordType = function (recordTypeId) { | |||
| return { | |||
| '@id': 'recordType:' + recordTypeId, | |||
There was a problem hiding this comment.
I don't think we need the recordType: namespace here. 1) it's not a namespace we define anywhere, and 2) we're don't appear to be doing the same thing in the aggregation. So just drop the recordType:?
Alternatively, to make this more consistent and json-ld-ish:
- add same namespace to the recordType aggregation values
- ensure that when
?filters[recordType]=is used, we allow the namespace to be optionally used in ids, i.e. stripped, so that front-end doesn't need to remove it when filtering - add namespace definition to relevant context file (
"recordType": "nypl:recordType")
There was a problem hiding this comment.
i opt for the first! makes sense.
lib/jsonld_serializers.js
Outdated
| @@ -485,6 +498,10 @@ class AggregationSerializer extends JsonLdItemSerializer { | |||
| } else if (field === 'buildingLocation') { | |||
| // Build buildingLocation agg labels from nypl-core: | |||
| v.label = locations[v.value]?.label | |||
| } else if (field === 'recordType') { | |||
| console.log(v) | |||
nonword
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recordTypewith json LD namespace and nypl core label to resources bib responserecordTypeto filtersrecrodTypeto search aggregations